Skip to content

Fix page workflow state when workflow disabled#7344

Merged
bdukes merged 2 commits into
dnnsoftware:developfrom
tvatavuk:feature/fix-7305-page-workflow-state
Jun 30, 2026
Merged

Fix page workflow state when workflow disabled#7344
bdukes merged 2 commits into
dnnsoftware:developfrom
tvatavuk:feature/fix-7305-page-workflow-state

Conversation

@tvatavuk

Copy link
Copy Markdown
Contributor

Fixes #7305

Summary

This PR prevents page-level workflow settings from being applied when workflow/versioning is disabled at the site level.

Root cause: the Pages settings UI could submit workflow/versioning values even when those features were disabled globally. The saved tab settings then poisoned the page workflow state, so newly added Text/HTML modules could be created as draft content and remain hidden in view mode.

The fix keeps page workflow/versioning disabled unless the portal-level feature is enabled, so Text/HTML content is published normally on sites where workflow is not active.

Verified locally with:

  • clean DNN 10.3.2 install
  • site workflow/versioning disabled
  • page workflow/versioning toggled in page settings
  • newly added Text/HTML modules remain visible in view mode

@bdukes bdukes added this to the 10.3.3 milestone Jun 30, 2026
bdukes
bdukes previously approved these changes Jun 30, 2026

@bdukes bdukes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valadas valadas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetWorkflow_UsesDirectPublish_WhenTabHasStateButWorkflowIsDisabled currently fails but other than that nothing sticks out to me

Add test caching provider
@bdukes
bdukes enabled auto-merge June 30, 2026 19:28
@bdukes
bdukes added this pull request to the merge queue Jun 30, 2026
Merged via the queue into dnnsoftware:develop with commit cb7cebe Jun 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: On upgraded site (10.2.3 -> 10.3.2), new HTML modules remain Draft/Unpublished and do not render, while existing HTML modules still work

4 participants