Skip to content

Add an AppOffline.htm when the local upgrade process is unpacking files#7328

Merged
bdukes merged 8 commits into
dnnsoftware:developfrom
donker:202606-appoffline
Jul 14, 2026
Merged

Add an AppOffline.htm when the local upgrade process is unpacking files#7328
bdukes merged 8 commits into
dnnsoftware:developfrom
donker:202606-appoffline

Conversation

@donker

@donker donker commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR writes an AppOffline.htm to the root of DNN while a DNN install package is being written over the current installation. It ensures that another user can't access DNN while this process is going on.

Secondly this PR introduces "BackupFiles" as a boolean with default true to the FileInstaller allowing logic to skip backing up files. The local upgrade will not backup assemblies while installing as we do not support rolling back DNN installations to previous versions. The local upgrade process clearly states one should backup the entire installation before the upgrade commences.

mitchelsellers
mitchelsellers previously approved these changes Jun 30, 2026
@mitchelsellers

Copy link
Copy Markdown
Contributor

Suggested testing notes.

"New AppOffline process to show users that upgrades are in process using the upgrade experience. Ideally testing for any issues across different hosting environments; local, Microsoft Azure, Amazon Cloud, etc. Concern areas include unable to complete installations or hung-sites resulting in a manual removal of appoffline.htm"

@Timo-Breumelhof

Copy link
Copy Markdown
Contributor

IMO it would be good if we had a standard filename like AppOffline.htm.bak or _AppOffline.htm and the system would rename that file instead of place it's own.
We have styling in AppOffline.htm(.bak) for some of our clients for upgrades.

@mitchelsellers

Copy link
Copy Markdown
Contributor

@donker can you confirm these two path expectaions for finding/copying the file?

var appOfflineFile = Path.Combine(Globals.HostMapPath, "AppOffline", "App_Offline.htm");
        if (!File.Exists(appOfflineFile))
        {
            appOfflineFile = Path.Combine(this.appStatus.ApplicationMapPath, "Resources", "AppOffline", "App_Offline.htm");
        }

Comment thread DNN Platform/Website/Resources/AppOffline/App_Offline.htm.resources
@bdukes

bdukes commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
screenshot of default app_offline.htm

Comment thread DNN Platform/Website/Resources/AppOffline/App_Offline.htm.resources
Comment thread DNN Platform/Website/DotNetNuke.Website.csproj Outdated
bdukes
bdukes previously approved these changes Jul 14, 2026
@bdukes
bdukes enabled auto-merge July 14, 2026 20:58
@bdukes
bdukes force-pushed the 202606-appoffline branch from ff348f6 to 9d09b25 Compare July 14, 2026 20:58
@bdukes
bdukes added this pull request to the merge queue Jul 14, 2026
@bdukes
bdukes removed this pull request from the merge queue due to a manual request Jul 14, 2026
@bdukes
bdukes added this pull request to the merge queue Jul 14, 2026
Merged via the queue into dnnsoftware:develop with commit 239a417 Jul 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants