Skip to content

Add folder icon to Site Assets root node in Resource Manager.#7314

Merged
valadas merged 2 commits into
dnnsoftware:developfrom
r90727:fix/7311-site-assets-root-folder-icon
Jun 8, 2026
Merged

Add folder icon to Site Assets root node in Resource Manager.#7314
valadas merged 2 commits into
dnnsoftware:developfrom
r90727:fix/7311-site-assets-root-folder-icon

Conversation

@r90727

@r90727 r90727 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Fixes #7311

Summary

Added folder icon to Site Assets root node in Resource Manager. Reused icon rendering code from dnn-rm-folder-list-item.tsx

valadas
valadas previously approved these changes Jun 7, 2026

@valadas valadas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me. Was this tested with the module used in the context of Group mode and User mode?

@r90727

r90727 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

The code looks fine to me. Was this tested with the module used in the context of Group mode and User mode?

no, didn't realize it was used in other places, will test and report back

@r90727

r90727 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Tested User and Group mode (had to fake out page url for the group, as I don't know how those actually work, i.e. http://dnn_7311.dnndev.me/default.aspx?groupid=1)

Both look good. Also tested "Move" popup.

Screenshot 2026-06-07 093007

##Group Mode
Screenshot 2026-06-07 094639

##User Mode
Screenshot 2026-06-07 093138

@valadas

valadas commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for testing that out, it would be nice to put a bit of space between the icon and the text like the others have.

@valadas valadas added this to the 10.3.3 milestone Jun 7, 2026
@r90727
r90727 force-pushed the fix/7311-site-assets-root-folder-icon branch from 32c02b4 to 7dc87bd Compare June 7, 2026 18:29
@r90727

r90727 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Done
Screenshot 2026-06-07 102324

@valadas

valadas commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Awesome, thanks @r90727

@bdukes bdukes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valadas
valadas added this pull request to the merge queue Jun 8, 2026
Merged via the queue into dnnsoftware:develop with commit eb1276f Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add "folder" icon to Site Assets root node

3 participants