Skip to content

Better support for empty elements in manifest.#7302

Merged
bdukes merged 4 commits into
dnnsoftware:developfrom
dimarobert:manifest-empty-elements
Jun 3, 2026
Merged

Better support for empty elements in manifest.#7302
bdukes merged 4 commits into
dnnsoftware:developfrom
dimarobert:manifest-empty-elements

Conversation

@dimarobert

@dimarobert dimarobert commented May 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #7301

Summary

Adds support for both forms of empty elements in manifest.

As the documentation states, System.Xml.XmlReader.IsEmptyElement supports only self-closing elements:

gets a value indicating whether the current node is an empty element (for example, <MyElement/>).

Returns
   true if the current node is an element (NodeType equals XmlNodeType.Element) that ends with />; otherwise, false.

@bdukes bdukes added this to the 10.3.3 milestone May 29, 2026
bdukes
bdukes previously approved these changes May 29, 2026
@bdukes

bdukes commented May 29, 2026

Copy link
Copy Markdown
Contributor

Thanks! I pushed a couple of commits to add on to your changes.

  1. I added some tests to verify what should be happening here.
  2. I added a helper XmlUtils.TryReadEndElement, which also handles an element which has only whitespace.

@bdukes
bdukes enabled auto-merge May 29, 2026 19:48
Comment thread DNN Platform/Library/Entities/Modules/DesktopModuleInfo.cs Outdated
@bdukes
bdukes force-pushed the manifest-empty-elements branch from 39bddf0 to 6e7d375 Compare June 1, 2026 13:23
@bdukes
bdukes added this pull request to the merge queue Jun 3, 2026
Merged via the queue into dnnsoftware:develop with commit 208c996 Jun 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Manifest has partial support for empty XML elements.

3 participants