FIX: Site crawler regex improvement #7191#7192
Merged
mitchelsellers merged 6 commits intoApr 8, 2026
Merged
Conversation
mitchelsellers
previously approved these changes
Apr 7, 2026
mitchelsellers
left a comment
mitchelsellers
left a comment
Contributor
There was a problem hiding this comment.
I think t his is a good fix for right nwo with the lower level risk.
@dnnsoftware/approvers I know there was a larger discussion about using HtmlSanitizer for this, but not sure that we want to go to the larger changge here at this time?
Thoughts?
valadas
previously requested changes
Apr 8, 2026
Contributor
|
As for HtmlSanitizer, I think it would be best since we already have it and we don't have to think about all the edge cases that might arise by doing our own regexes IMO... But I won't die on that hill ;) |
bdukes
reviewed
Apr 8, 2026
Co-authored-by: Brian Dukes <[email protected]>
Co-authored-by: Brian Dukes <[email protected]>
Contributor
Author
|
I made the requested changes. |
bdukes
approved these changes
Apr 8, 2026
mitchelsellers
approved these changes
Apr 8, 2026
mitchelsellers
left a comment
mitchelsellers
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the updates!
mitchelsellers
dismissed
valadas’s stale review
April 8, 2026 19:36
This change was made & we have 2 approvals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7191
Summary
Bug fix and performance improvement for HTML tag processing in the search controller.
This PR enhances the reliability and efficiency of HTML tag stripping and attribute extraction in InternalSearchControllerImpl by improving regex usage and error handling.