Get ContentEditorManager dependencies from request scope#6950
Merged
Conversation
The ClientResourceController needs to be scoped to the request, since it is stateful.
valadas
approved these changes
Jan 29, 2026
valadas
left a comment
valadas
left a comment
Contributor
There was a problem hiding this comment.
Excellent! Thanks again!
david-poindexter
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In DNN 10.2.2 RC1, the edit bar does not display in edit mode. There is an error in the console about
dnn.ContentEditorManagerbeing undefined, which points toContentEditor.jsnot being registered byContentEditorManager.This line was successfully running, but when the scripts were rendered on the page, the script was not in the list of requested scripts. This is because the
IClientResourceControllerpassed to the constructor ofContentEditorManagerdid not come from the current request scope, but was created whenEditBarModulewas instantiated was instantiated (due to timing issues with DI support inIHttpModuleimplementations).The solution in this PR is to get the dependencies from the request scope when needed, rather than using constructor injection.