Enhance font-weight for bold elements in SCSS#6897
Conversation
valadas
left a comment
valadas
left a comment
There was a problem hiding this comment.
This looks like an OK solution, however @david-poindexter would you be open to instead refactor the _reset.css which I believe may be a bit old reference with things maybe too strong and lacking more modern elements.
Something like https://www.npmjs.com/package/modern-normalize
|
@dnnsoftware/approvers What do we think about just getting this one approved? |
|
I think we should instead replace https://github.com/dnnsoftware/Dnn.Platform/blob/develop/DNN%20Platform/Dnn.ClientSide/src/styles/default-css/10.0.0/base/_reset.scss with https://www.npmjs.com/package/modern-normalize This issue may affect parts where the theme is not used as it is very global, so it looks like a better fix to me and reduces code instead of adding. |
But that would change the scope of this issue. How about incorporating this and then fixing the reset in another PR and you can roll this change back at that point? |
|
I would agree with @donker I think at this point, as the change to reset at the 10.0.0 level would have more of an impact than just the Aperture theme |
5 participants
Fixes #6755
Summary
This PR fixes an issue where
<strong>and<b>elements were not rendered as bold in the Aperture theme.A global reset rule was inheriting the full
fontproperty for these elements, which unintentionally removed the browser default bold behavior and caused them to render with the same font weight as their parent.An explicit override using:
b, strong { font-weight: bolder; }restores the expected semantic behavior by matching standard user-agent styling, without hard-coding a specific font weight or impacting layout and typography elsewhere.