Restored /Tests folder to state in previous commit#6826
Merged
Conversation
Contributor
Author
|
Well, that was apparently not to fix. I will leave this PR here however as a reference until we pinpoint the proper fix. |
valadas
marked this pull request as draft
December 3, 2025 07:56
bdukes
force-pushed
the
revert-tests-folder
branch
from
December 3, 2025 14:14
b76feca to
96faabe
Compare
Contributor
|
I was able to grab some of the details of that commit and revert it more directly, I've pushed that to your branch |
bdukes
marked this pull request as ready for review
December 3, 2025 14:57
bdukes
approved these changes
Dec 3, 2025
Contributor
Author
|
Perfect, thanks @bdukes |
bdukes
force-pushed
the
revert-tests-folder
branch
from
December 3, 2025 20:03
96faabe to
2d37928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in 4a4bcbc all the test projects were modified in a way were they would reference a duplicate app.config
I tried reverting only that change but it did not fix the broken tests. This reverts the whole Tests folder to the state it was in the very previous commit where the tests were fine.
I am not sure this is the proper solution to the failing tests @bdukes do you have opinions or a better fix?
Summary