Use SVGR for icons#6808
Merged
Merged
Conversation
bdukes
force-pushed
the
svgr-for-icons
branch
3 times, most recently
from
November 20, 2025 23:27
4b947d3 to
df963ef
Compare
valadas
requested changes
Nov 21, 2025
valadas
left a comment
valadas
left a comment
Contributor
There was a problem hiding this comment.
That is awesome, now I downloaded the CI build and went to every module, everything worked fine except the Users module blows up...
bdukes
force-pushed
the
svgr-for-icons
branch
from
November 21, 2025 14:25
df963ef to
757eaac
Compare
Contributor
Author
|
Thanks for testing @valadas, I've fixed the issue in the Users module |
Contributor
|
I'm late to the party, but just wanted to say thanks @bdukes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the approach to loading SVG icons in the Persona Bar to use SVGR's Webpack loader to convert the SVG files into components (while also optimizing them).