Skip to content

DNN-6746: improving returned load size from /Install/installstat.log....#333

Merged
cathalconnolly merged 2 commits into
developmentfrom
bug/SOCIAL-3234
Apr 16, 2015
Merged

DNN-6746: improving returned load size from /Install/installstat.log....#333
cathalconnolly merged 2 commits into
developmentfrom
bug/SOCIAL-3234

Conversation

@galatrash

Copy link
Copy Markdown
Contributor

...resources.txt endpoint

I added two minor fixes as well

  • formatting installer log date as yyyyMMdd instead of yyyyMd
  • made installer log entries date/time stamp local (same as regular logs) instead of UTC.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the install at UTC time. Installs occur on the "server" which is not guaranteed to be in the same timezone as the administrator doing the install (this is especially true in cloud environments). Using UTC ensures that users can easily figure out the correct time for their location.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this to be the same as the regular log files. I heard it from QA that they had problem relating bugs to actual lines between the two log files (regular and installation). IMO, both should have the same format; either both are UTC or local time but not one UTC and the other local.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all dates should be in the UTC time, and translated for display. If QA has a problem with the way dates are stored then they need to create a proper Jira so that it can be discussed by the PMs. Please back out that single change so we can merge the rest of this fix. I am happy to deal with the date issue on a separate Jira item.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted that date back to UTC and included it in the same pull request.

@jbrinkman jbrinkman added Community Legacy label used to identify community contributions and removed Community Legacy label used to identify community contributions labels Mar 7, 2015
@cathalconnolly cathalconnolly self-assigned this Mar 11, 2015
@cathalconnolly

Copy link
Copy Markdown

can you please clone the social ticket as a platform ticket so we have a valid public jira to associate this with

@ashishpd

Copy link
Copy Markdown
Contributor

@cathalconnolly

Copy link
Copy Markdown

thanks, i'll review and merge tomorrow

@jbrinkman jbrinkman added this to the 7.4.1 milestone Mar 17, 2015
@cathalconnolly cathalconnolly changed the title SOCIAL-3234: improving returned load size from /Install/installstat.log.... DNN-6746: improving returned load size from /Install/installstat.log.... Mar 18, 2015
@cathalconnolly

Copy link
Copy Markdown

merging into development and cherrypicking into release/7.4.1

cathalconnolly pushed a commit that referenced this pull request Apr 16, 2015
DNN-6746: improving returned load size from /Install/installstat.log....
@cathalconnolly
cathalconnolly merged commit b8e891f into development Apr 16, 2015
@cathalconnolly
cathalconnolly deleted the bug/SOCIAL-3234 branch April 16, 2015 12:46
cathalconnolly pushed a commit that referenced this pull request Apr 16, 2015
DNN-6746: improving returned load size from /Install/installstat.log....
@cathalconnolly cathalconnolly removed their assignment Jun 17, 2015
@jbrinkman jbrinkman added nop and removed nop labels Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants