Improved decompilation and mapping of BAML connection ID records#197
Merged
ElektroKill merged 3 commits intomasterfrom May 15, 2023
Merged
Improved decompilation and mapping of BAML connection ID records#197ElektroKill merged 3 commits intomasterfrom
ElektroKill merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this pull request covers:
N/A
Problem
The BAML decompiler did not thoroughly analyze the if-else structures found in the implementations of the
IStyleConnector.ConnectandIComponentConnector.Connectmethods. The analysis of theIStyleConnector.Connectmethod was also partially broken due to the hardcoded check for the_contentLoadedfield store only present inIComponentConnector.Connectimplementations.Furthermore, the handling of
EventSetterelements did not account for cases where more than oneEventSetterwas present per connection ID.Solution
Resolve the above issues by reimplementing the algorithms for analyzing if-else structures and adjusting the handling of
EventSetterelements to allow more than one per connection ID.