prevent AggregateException when connecting to unity process#190
Merged
ElektroKill merged 2 commits intodnSpyEx:masterfrom Apr 26, 2023
Merged
prevent AggregateException when connecting to unity process#190ElektroKill merged 2 commits intodnSpyEx:masterfrom
AggregateException when connecting to unity process#190ElektroKill merged 2 commits intodnSpyEx:masterfrom
Conversation
ElektroKill
requested changes
Apr 26, 2023
Extensions/dnSpy.Debugger/dnSpy.Debugger.DotNet.Mono/Impl/DbgEngineImpl.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+435
to
+439
| catch (AggregateException aex) when (aex.InnerExceptions.All(ex => ex is SocketException { | ||
| SocketErrorCode: SocketError.ConnectionRefused | ||
| })) { | ||
| // Retry it in case it takes a while | ||
| } |
Member
There was a problem hiding this comment.
Would it not be better to check if InnerExceptions contains only one element which is the SocketException instead of testing every single one? Is it possible for InnerExceptions to contain more than one SocketException from the code inside the try?
Author
There was a problem hiding this comment.
I don't think it's possible but if it really happens, this logic is still most likely correct and you don't have to fix it again. Anyway, I will change it if you insist.
ElektroKill
approved these changes
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this pull request covers: #189
Problem
This should fix #189
Solution
Catch
AggregateException, too.