Skip to content

fix(js-jods): Propert support for date-only and time-only in mergeDateAndTime method#653

Merged
dmtrKovalenko merged 2 commits into
dmtrKovalenko:masterfrom
joshkel:js-joda-merge-date-time
Jan 10, 2024
Merged

fix(js-jods): Propert support for date-only and time-only in mergeDateAndTime method#653
dmtrKovalenko merged 2 commits into
dmtrKovalenko:masterfrom
joshkel:js-joda-merge-date-time

Conversation

@joshkel

@joshkel joshkel commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

See mui/mui-x#4703 (comment) (although note that mui-x no longer uses date-io).

See mui/mui-x#4703 (comment) (although note that mui-x no longer uses date-io)
@dmtrKovalenko dmtrKovalenko changed the title Add support for date-only and time-only to js-joda fix(js-jods): Propert support for date-only and time-only to js-joda Sep 12, 2023
@dmtrKovalenko dmtrKovalenko changed the title fix(js-jods): Propert support for date-only and time-only to js-joda fix(js-jods): Propert support for date-only and time-only in mergeDateAndTime method Sep 12, 2023
@dmtrKovalenko
dmtrKovalenko self-requested a review September 12, 2023 14:38

@dmtrKovalenko dmtrKovalenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't let this fix in because it reduces code coverage

@joshkel

joshkel commented Sep 12, 2023

Copy link
Copy Markdown
Contributor Author

@dmtrKovalenko Fixed. Thanks.

@dmtrKovalenko
dmtrKovalenko merged commit 4f78281 into dmtrKovalenko:master Jan 10, 2024
@joshkel
joshkel deleted the js-joda-merge-date-time branch January 10, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants