Skip to content

Remove useless date clone in dayjs adapter#615

Merged
flaviendelangle merged 1 commit into
dmtrKovalenko:masterfrom
flaviendelangle:remove-clone-day-js
May 13, 2022
Merged

Remove useless date clone in dayjs adapter#615
flaviendelangle merged 1 commit into
dmtrKovalenko:masterfrom
flaviendelangle:remove-clone-day-js

Conversation

@flaviendelangle

Copy link
Copy Markdown
Collaborator

Follow up on #614

dayjs is immutable out of the box, we don't need to clone the date before calling add / substract / endOf / startOf or set

@flaviendelangle flaviendelangle added the enhancement New feature or request label May 13, 2022
@flaviendelangle flaviendelangle self-assigned this May 13, 2022
@flaviendelangle
flaviendelangle merged commit d8607ed into dmtrKovalenko:master May 13, 2022
@flaviendelangle
flaviendelangle deleted the remove-clone-day-js branch May 13, 2022 10:01
@flaviendelangle

Copy link
Copy Markdown
Collaborator Author

@dmtrKovalenko do you want to release today ?

@dmtrKovalenko

Copy link
Copy Markdown
Owner

Yeah I can make a release

This was referenced Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants