Remove --mpi from restart related code.#1231
Conversation
📝 WalkthroughWalkthroughThis pull request removes MPI-related command-line option handling from two restart utility files. Specifically, the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated --mpi flag from DMTCP restart-related code, as MANA now uses its kernel-loader for restart functionality instead. The changes include a version bump from 4.0.0 to 4.1.0 and updated release notes.
Key changes:
- Removal of
--mpiflag handling from restart argument parsing in both mtcp_restart and dmtcp_restart - Version bump to 4.1.0 with accompanying updates to configure scripts
- Addition of release notes documenting new features in version 4.1.0
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/mtcp/mtcp_restart.c | Removed --mpi flag parsing and associated mpiMode logic from restart process argument handling |
| src/dmtcprestartinternal.cpp | Removed --mpi flag from usage documentation and argument parsing, eliminating runMpiProxy variable assignment |
| configure.ac | Updated AC_INIT formatting to single line, bumped AC_PREREQ to 2.72 |
| configure | Regenerated configure script reflecting version 4.1.0 and autoconf 2.72 updates |
| VERSION | Bumped version from 4.0.0 to 4.1.0 |
| NEWS | Added release notes for version 4.1.0 with feature highlights and bug fixes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MANA uses its kernel-loader to restart. So the --mpi flag in DMTCP is deprecated.
Summary by CodeRabbit
--mpiflag) from the restart command-line interface and its associated argument processing, simplifying restart behavior by discontinuing MPI-specific handling.✏️ Tip: You can customize this high-level summary in your review settings.