Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a corner case in handling epoll_wait events by ensuring that EPOLLIN events are processed before EPOLLHUP to avoid dropping messages when clients disconnect immediately after sending data.
- EPOLLIN events are now handled first to read any incoming data from client sockets.
- The disconnection events (EPOLLHUP, EPOLLRDHUP, EPOLLERR) are checked afterward to safely detach sockets.
When processing epoll_wait events, EPOLLIN should be processed before EPOLLHUP. This ensures no messages are dropped if a client disconnects immediately after sending a message.
karya0
force-pushed
the
dev/karya0/coord-epoll
branch
from
b82de2e to
ebbce88
Compare
xuyao0127
approved these changes
May 5, 2025
Collaborator
xuyao0127
left a comment
xuyao0127
left a comment
There was a problem hiding this comment.
I'm approving to unblock your progress. I'm not familiar with this part of DMTCP. Maybe Gene can provide more feedback.
Member
Author
|
Thanks @xuyao0127. I'll merge it now. If @gc00 has any comments, I'll create a follow-up PR to address them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When processing epoll_wait events, EPOLLIN should be processed before EPOLLHUP. This ensures no messages are dropped if a client disconnects immediately after sending a message.