Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes initialization issues when using non-glibc malloc libraries and when constructors are called before DMTCP is fully initialized. Key changes include:
- Returning a status from ThreadSync::libdlLockLock() to conditionally unlock in LibDlWrapperLock.
- Adding a conditional block to close file descriptors only when appropriate.
- Updating PID mapping functions to handle pid values of 0 as special cases.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/wrapperlock.cpp | Adjusts lock acquisition and conditional unlocking logic. |
| src/shareddata.cpp | Fixes file descriptor management during initialization. |
| src/plugin/pid/virtualpidtable.cpp | Updates PID translation functions to handle special pid cases. |
| include/wrapperlock.h | Declares new private member for tracking lock acquisition. |
Comments suppressed due to low confidence (1)
include/wrapperlock.h:52
- [nitpick] Confirm that the in-class initializer for 'acquired' is consistent with the project's coding style; if compatibility issues arise, consider initializing this member in the constructor's initializer list instead.
bool acquired = false;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fix issues that are observed during initialization when non-glibc malloc libraries and programs where constructors are called before DMTCP is fully initialized.