Check if plugins need to skip nscd regions#1194
Merged
xuyao0127 merged 2 commits intodmtcp:mainfrom Mar 4, 2025
Merged
Conversation
karya0
requested changes
Mar 3, 2025
Member
I already suggested the cleaner way in the comment earlier : ). Re-elaborated it. @xuyao0127: Feel free to merge it as is for now, but please make sure to create a separate PR to clean it. |
karya0
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug when writing memory areas to disk. Previously, nscd areas are written to the disk before calling the
dmtcp_skip_memory_region_ckpting()functions. Therefore, no matter if a plugin decides to skip the nscd area, the nscd area will always be written to the disk.