Fix shmget wrapper to preserve original key values on first use.#1191
Closed
gkliu wants to merge 1 commit intodmtcp:mainfrom
Closed
Fix shmget wrapper to preserve original key values on first use.#1191gkliu wants to merge 1 commit intodmtcp:mainfrom
gkliu wants to merge 1 commit intodmtcp:mainfrom
Conversation
… typically indicates that this key is being used for the first time by user code. In this case, we need to preserve the original key value rather than translating it. This ensures that explicit key values specified by the application are maintained, which is important for applications that rely on specific key values for their shared memory regions.
Member
Member
Author
|
Many thanks, @karya0. I tested my use cases and they are working well. Really appreciated it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When wrapping the shmget function, this PR fixes the handling of non-IPC_PRIVATE keys.
Previously, when VIRTUAL_TO_REAL_SHM_KEY returns -1 (indicating the key is being used for the first time by user code), we need to preserve the original key value rather than attempting to translate it. This ensures that explicit key values specified by the application are maintained correctly.
This fix is important for applications that rely on specific key values for their shared memory regions, as it ensures the DMTCP wrapper doesn't modify these values on first use.