Avoid overflow in rounding estimation.#11910
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential integer overflow issue in the rounding estimation algorithm by changing the parameter type of CreateRoundingFactor from int to bst_idx_t (uint64_t), allowing it to handle datasets with more than 2.1 billion rows without overflow.
Key changes:
- Updated
CreateRoundingFactorto acceptbst_idx_tinstead ofintfor the row count parameter, preventing overflow for large datasets - Changed gradient pair types in histogram computation from
GradientPairtoGradientPairPrecisefor improved numerical precision - Modernized initialization syntax from parentheses to braces for gradient pair construction
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/common/deterministic.cuh | Updated CreateRoundingFactor parameter from int to bst_idx_t to handle large row counts; updated copyright year and improved include comments |
| src/tree/gpu_hist/histogram.cu | Changed gradient pair types to GradientPairPrecise for higher precision and modernized initialization syntax to use braces instead of parentheses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
cc @rongou |
rongou
approved these changes
Jan 5, 2026
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jan 6, 2026
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jan 7, 2026
trivialfis
added a commit
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.