[mt] Implement prediction cache.#11862
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements prediction cache support for multi-target trees in the GPU histogram tree builder. The prediction cache stores the final node positions for training samples, enabling faster prediction updates without having to traverse the tree for each prediction.
Key Changes
- Added
positions_member variable to cache node indices for each sample in multi-target training - Implemented
FinalizePositionmethod to compute and store final leaf positions after tree construction - Implemented
UpdatePredictionCachemethod to update predictions using cached positions - Refactored histogram allocation logic by changing
force_globalflag from true to false for better memory efficiency
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tree/updater_gpu_hist.cuh | Added prediction cache infrastructure for multi-target trees including positions storage, FinalizePosition and UpdatePredictionCache methods |
| src/tree/updater_gpu_hist.cu | Updated UpdatePredictionCache to support both single-target and multi-target trees, improved variable naming consistency (d_matrix → d_acc), and enhanced code comments |
| src/tree/gpu_hist/histogram.cuh | Refactored subtraction logic by extracting CanSubtract helper method for improved code organization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
trivialfis
marked this pull request as ready for review
December 12, 2025 15:55
Member
Author
|
cc @rongou |
rongou
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #9043