Fix mingw warnings.#11859
Merged
Merged
Conversation
trivialfis
requested review from
Copilot and
hcho3
and removed request for
Copilot
December 11, 2025 12:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MinGW-specific warnings related to socket handling by ensuring proper cross-platform socket error checking and header inclusion patterns.
- Updated socket error check to use
INVALID_SOCKETinstead of hardcoded-1 - Modified
_WINSOCKAPI_macro definition to avoid conflicts with MinGW's header handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/collective/tracker.cc | Changed socket creation error check from -1 to INVALID_SOCKET for proper cross-platform compatibility |
| include/xgboost/windefs.h | Added MinGW-specific condition to prevent defining _WINSOCKAPI_ which conflicts with MinGW's internal header management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hcho3
approved these changes
Dec 12, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jan 3, 2026
trivialfis
added a commit
that referenced
this pull request
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #11851 .