Fix loading nccl 2.28.#11806
Merged
Merged
Conversation
This was referenced Nov 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with loading NCCL 2.28, which doesn't have the __file__ attribute. The fix extracts NCCL library path detection into a separate function that handles both the traditional __file__ attribute and the newer __path__ attribute used in NCCL 2.28.
Key changes:
- Extracted NCCL path detection logic into a new
_find_nccl()function - Added support for
__path__attribute to handle NCCL 2.28 - Changed from hardcoded
libnccl.so.2to dynamic discovery of anylibnccl.so*file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Member
Author
|
cc @rongou |
hcho3
approved these changes
Nov 12, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Nov 19, 2025
trivialfis
added a commit
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #11804
The latest nccl pypi package no longer has the
__file__attribute in its modules (it no longer has modules). We will use the__path__from the namespace instead.