Check for removed binary format.#11760
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds an explicit check to detect legacy binary model files and fail fast with a clear message, addressing the removed binary format.
- Introduces a reusable error message helper for removed binary format.
- Blocks loading of legacy binary models by detecting the "binf" magic header and emitting a fatal log with guidance.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/common/error_msg.h | Adds a helper function returning a detailed message about the removed binary format with docs link. |
| src/c_api/c_api.cc | Detects "binf" header in loaded bytes and aborts with the new error message instead of proceeding. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
cc @hcho3 |
ikrommyd
approved these changes
Oct 20, 2025
ikrommyd
left a comment
ikrommyd
left a comment
There was a problem hiding this comment.
Thanks! I think this can help users who try to load old models understand better what's happening!
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Oct 21, 2025
trivialfis
added a commit
that referenced
this pull request
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #11758