Avoid using mean intercept for rmsle.#11588
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the root mean squared logarithmic error (RMSLE) objective to avoid using mean intercept for regression. The changes address issue #11442 by creating a new implementation that inherits from FitIntercept instead of the shared RegLossObj class which uses FitInterceptGlmLike.
- Extracts label validation logic into a standalone template function
- Creates a new
SquaredLogErrorRegressionclass that inherits fromFitInterceptinstead of using the sharedRegLossObj - Removes unused includes and updates copyright years
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/objective/regression_obj.cu | Refactors RMSLE implementation with new class and extracted validation logic |
| src/objective/regression_loss.h | Removes unused include and updates copyright |
| src/objective/quantile_obj.cu | Removes unused includes and updates copyright |
Comments suppressed due to low confidence (1)
src/objective/regression_obj.cu:119
- The function call should be
ValidateLabel<Loss>instead ofValidateLabel<Loss>since the extracted function is now a template function, but the template parameter syntax is inconsistent with the function definition which doesn't show template parameters.
ValidateLabel<Loss>(this->ctx_, info);
hcho3
approved these changes
Jul 26, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jul 28, 2025
trivialfis
added a commit
that referenced
this pull request
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #11442 .