Skip to content

Fix compilation of Xgboost on WoA#11559

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
MGN-GIT:WoA_Xgboost
Jul 14, 2025
Merged

Fix compilation of Xgboost on WoA#11559
trivialfis merged 1 commit into
dmlc:masterfrom
MGN-GIT:WoA_Xgboost

Conversation

@MGN-GIT

@MGN-GIT MGN-GIT commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

PR Description:

  • The PR fixes compilation of Xgboost library on WoA(Windows on ARM).
  • Building xgboost from source on native WoA device fails while including bitfield.h header due to x64 based intrinsic function call _tzcnt_u32(v).
  • The PR adds a macro to call _tzcnt_u32(v) only for x64 based MSVC-like compilers
  • This leads to successful build of xgboost on WoA using MSVC toolchain.

trivialfis
trivialfis approved these changes Jul 14, 2025
View reviewed changes

@trivialfis trivialfis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Will merge once we can restore the CI.

@MGN-GIT

MGN-GIT commented Jul 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Welcome :) , Additionally I would like to contribute to add support for xgboost python wheels on WoA. @trivialfis your guidance would be high appreciated to make xgboost available for this growing platform

@trivialfis

trivialfis commented Jul 14, 2025

Copy link
Copy Markdown
Member

Thank you for working on Windows on ARM. Yeah, I would like to get one of those one day.

In the meantime, I will ping @hcho3 for CI work regarding packaging. I'm not familiar with the Windows CI pipeline.

@trivialfis trivialfis mentioned this pull request Jul 14, 2025
Open
@khmyznikov khmyznikov mentioned this pull request Jul 14, 2025
Open
@trivialfis
trivialfis merged commit ad29598 into dmlc:master Jul 14, 2025
100 of 110 checks passed
@MGN-GIT

MGN-GIT commented Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

In the meantime, I will ping @hcho3 for CI work regarding packaging. I'm not familiar with the Windows CI pipeline.

@hcho3 could you provide me with necessary details regarding XGBoost python wheels pipeline for Windows.

@hcho3

hcho3 commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@lowkeyrossi I believe GitHub Actions now provide free minutes for Windows ARM builds. Would you be interested in submitting a draft pull request to build and test XGBoost on Windows ARM using GitHub Actions? I plan to build on your pull request to set up automated builds for Python wheels.

@MGN-GIT

MGN-GIT commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

Is it fine to create a separate workflow file for building XGBoost python wheels on Windows arm64 runner?

@hcho3

hcho3 commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

Yes, please create a separate workflow

hcho3 pushed a commit to hcho3/xgboost that referenced this pull request Jul 30, 2025
@MGN-GIT @hcho3
Fix compilation on WoA (dmlc#11559)
46280b5
@hcho3 hcho3 mentioned this pull request Jul 30, 2025
Closed
10 tasks
hcho3 added a commit that referenced this pull request Jul 30, 2025
@hcho3 @MGN-GIT
[backport] Add support for building xgboost wheels on Win-ARM64 (#11572…
710f6cb 
…, #11597, #11559) (#11599)

* Add support for building xgboost wheels on Win-ARM64 (#11572)

* Add support for building xgboost wheels on Win-ARM64

* Add CI support for building xgboost wheels for WoA

* Fix wheel upload with WoA (#11597)

* [WIP] Debug wheel build with WoA

* Add back conditional

* Fix compilation on WoA (#11559)

---------

Co-authored-by: newyork_loki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MGN-GIT @trivialfis @hcho3