Fix NDCG metric with non-exp gain.#11534
Merged
Merged
Conversation
hcho3
approved these changes
Jun 26, 2025
hcho3
reviewed
Jun 26, 2025
Comment on lines
+108
to
+117
| TEST(XGBoostParameter, Json) { | ||
| UpdatableParam a, b; | ||
| a.UpdateAllowUnknown(Args{{"f", "1024"}, {"d", "2048"}}); | ||
| auto ja = Json{ToJson(a)}; | ||
|
|
||
| UpdatableParam c; | ||
| FromJson(ja, &c); | ||
| ASSERT_FLOAT_EQ(a.f, 1024); | ||
| ASSERT_FLOAT_EQ(c.f, 1024); | ||
| ASSERT_FLOAT_EQ(b.f, 0); // Make sure dmlc global variable is not used here. |
Member
Author
There was a problem hiding this comment.
I have difficulty understanding how the global parameter manager is implemented in dmlc. Just to make sure updating one parameter doesn't affect others with the same type.
hcho3
approved these changes
Jun 26, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jul 23, 2025
trivialfis
added a commit
to trivialfis/xgboost
that referenced
this pull request
Jul 23, 2025
trivialfis
added a commit
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #11517 .