Remove LOG_EQ to fix #10171#11386
Conversation
There was a problem hiding this comment.
Thank you for looking into this. I think the check is useful for preventing silent error. If the error is not checked, then the logic of this function is broken as it relies on the returned error.
Could you please share the underlying cause of an error being leaked into XGBoost?
|
In some cases it seems cudaPointerGetAttributes is returning cudaSuccess and not setting the last error, which means if something else has previously caused an error with cuda, you blow up here. I don't really know what the cause of that previous error is, but the situation is this:
|
|
I suppose alternatively you could call cudaGetLastError before cudaPointerGetAttributes in addition to the existing check. |
This sounds like a better workaround, would you like to help make the change? |
|
@hcho3 can this be cherry-picked into the next 3.x release please? |
|
I created #11494 to keep track of the upcoming patch release. Until the new patch release is out, consider using a nightly distribution instead: https://xgboost.readthedocs.io/en/release_3.0.0/install.html#id1 |
Co-authored-by: Austin Morton <[email protected]>
No description provided.