Fix all generator to support a memory leak fix #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this commit apache/mxnet#18328 , some memory leak were fixed. Whitout this commit faster rcnn traning cannot be successfully closed. These commits can be commit again after this yolo training fix. apache/mxnet#18692 apache/mxnet@0496690
chinakook
changed the title
Member
|
@chinakook looks good to me, can you take a look at the lint error? |
Member
|
Job PR-1528-6 is done. |
zhreshold
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a python property workaround to avoid the multiprocessing to pickle the
target generators, which will cause error before, especially on Windows.The error is associated with
ForkingPicklerofmultiprocessingpackage of python and be usually like:cannot pickle 'weakref' objectEOFError: Ran out of inputAfter the commit apache/mxnet#18328 , some memory leak were fixed. The commit is critical so we need to merge it again in MXNet 1.7.x and 1.8.x.
The revert commits below can be committed again after this fix. We can do gluon-cv training correctly and safety later.
apache/mxnet#18692
apache/mxnet@0496690