Update CMakeLists.txt: change min cmake version to 3.5#163
Merged
Conversation
rostan-t
added a commit
to rostan-t/free-threaded-python
that referenced
this pull request
Apr 1, 2025
cuDNN FE depends on dlpack 0.8, which uses CMake 3.2. CMake 4.0 dropped support for CMake<3.5. This shouldn't break anything in DLPack as a similar fix was done recently upstream (dmlc/dlpack#163). Signed-off-by: Rostan Tabet <[email protected]>
szalpal
pushed a commit
to NVIDIA/free-threaded-python
that referenced
this pull request
Apr 2, 2025
cuDNN FE depends on dlpack 0.8, which uses CMake 3.2. CMake 4.0 dropped support for CMake<3.5. This shouldn't break anything in DLPack as a similar fix was done recently upstream (dmlc/dlpack#163). Signed-off-by: Rostan Tabet <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMakeLists.txt: change min cmake version to 3.5, because cmake 4.0 dropped the support for cmake version <3.5. Otherwise this code cannot be compiled.