fatal error: concurrent map iteration and map write

chaunceyjiang · chaunceyjiang · commit 5a3a9baec96c · 2022-12-13T20:08:23.000+08:00
Signed-off-by: chaunceyjiang &lt;chaunceyjiang@gmail.com&gt;
diff --git a/pkg/cri/streaming/portforward/httpstream.go b/pkg/cri/streaming/portforward/httpstream.go
@@ -155,11 +155,11 @@ func (h *httpStreamHandler) getStreamPair(requestID string) (*httpStreamPair, bo
 func (h *httpStreamHandler) monitorStreamPair(p *httpStreamPair, timeout <-chan time.Time) {
 	select {
 	case <-timeout:
-		err := fmt.Errorf("(conn=%v, request=%s) timed out waiting for streams", h.conn, p.requestID)
+		err := fmt.Errorf("(conn=%p, request=%s) timed out waiting for streams", h.conn, p.requestID)
 		utilruntime.HandleError(err)
 		p.printError(err.Error())
 	case <-p.complete:
-		klog.V(5).Infof("(conn=%v, request=%s) successfully received error and data streams", h.conn, p.requestID)
+		klog.V(5).Infof("(conn=%p, request=%s) successfully received error and data streams", h.conn, p.requestID)
 	}
 	h.removeStreamPair(p.requestID)
 }

Original file line number	Diff line number	Diff line change
`@@ -155,11 +155,11 @@ func (h httpStreamHandler) getStreamPair(requestID string) (httpStreamPair, bo`
`155`	`155`	`func (h httpStreamHandler) monitorStreamPair(p httpStreamPair, timeout <-chan time.Time) {`
`156`	`156`	`select {`
`157`	`157`	`case <-timeout:`
`158`		`- err := fmt.Errorf("(conn=%v, request=%s) timed out waiting for streams", h.conn, p.requestID)`
	`158`	`+ err := fmt.Errorf("(conn=%p, request=%s) timed out waiting for streams", h.conn, p.requestID)`
`159`	`159`	`utilruntime.HandleError(err)`
`160`	`160`	`p.printError(err.Error())`
`161`	`161`	`case <-p.complete:`
`162`		`- klog.V(5).Infof("(conn=%v, request=%s) successfully received error and data streams", h.conn, p.requestID)`
	`162`	`+ klog.V(5).Infof("(conn=%p, request=%s) successfully received error and data streams", h.conn, p.requestID)`
`163`	`163`	`}`
`164`	`164`	`h.removeStreamPair(p.requestID)`
`165`	`165`	`}`