Update golang.org/x/tools to v0.31.0 and go to 1.24.1#108
Merged
dmarkham merged 1 commit intodmarkham:masterfrom Jan 21, 2026
Merged
Update golang.org/x/tools to v0.31.0 and go to 1.24.1#108dmarkham merged 1 commit intodmarkham:masterfrom
dmarkham merged 1 commit intodmarkham:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
|
When is this going to be merged? |
|
@dmarkham @samiam2013 Is there a timeline for this PR to be merged? This library has been a ton of help for our org but it is currently capping our golang version and we're unable to move forward – any updates would be very appreciated 🙏 |
Collaborator
|
I get so many notification emails from github, I usually miss these. Didn't know a tool change was blocking on enumer. I'll try to get to this soon, but things are abnormally busy around here. Sorry! |
|
Hey @samiam2013, Could you please come back to this PR? |
|
@dmarkham Hi, could you please review this PR? This fix can simplify our CI a lot, we are forced to manually clone a fork with this fix and install from the fork instead of simple |
dmarkham
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating our project version to 1.24 we had to bump enumer to v1.5.11 and it started failing for all our usages with
no value for constant <variable-name>.After bumping x/tools to v0.31.0 on enumer it works fine again (had to upgrade go too at the same time as it's required for the new version of x/tools.