Skip to content

fix(deps): allowlist npm-bundled undici for two new TLS advisories - #265

Merged
dlepaux merged 1 commit into
mainfrom
fix/rba-34-undici-advisories
Oct 29, 2026
Merged

dlepaux merged 1 commit into
mainfrom
fix/rba-34-undici-advisories

Conversation

@dlepaux

@dlepaux dlepaux commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Why

Since 2026-10-27, two new high undici advisories fail "Audit dependencies" on every PR, and on main too (seen on #264, run 40939767311):

Advisory Summary Fixed in
GHSA-2m5v-pch6-74hx TLS certificate validation bypass via dropped tls options in Agent 6.29.1 / 7.30.1 / 8.12.2
GHSA-qrxm-fqhp-jwvm DoS via TLS 1.2 certificate-changing renegotiation 6.29.1 / 7.30.1 / 8.12.2

The lockfile's own undici copies are already patched: #262 moved them to 6.29.1 (@actions/http-client) and 7.30.1 (@semantic-release/github). The only copy still affected is undici 6.29.0 bundled inside npm 11.21.1, which @semantic-release/npm pulls in. A bundled dependency can't be changed by a lockfile update or by overrides, and 11.21.1 is the newest npm 11 published.

What changes

bin/audit-gate.mjs only, with no lockfile change.

Once npm 11.21.2 is published, a targeted npm update npm should clear all three. The gate will then report the entries as stale, and they can be removed. If that hasn't happened, CI goes red again on 2026-11-16 and forces a re-check.

Dev and release tooling only. The library ships no runtime dependencies, so none of this reaches consumers.

Evidence

Locally with npm 11.19.1 (CI's version):

audit-gate self-test: ok
allowed: high undici GHSA-xjj6-f33q-929c ...
allowed: high undici GHSA-2m5v-pch6-74hx ...
allowed: high undici GHSA-qrxm-fqhp-jwvm ...
audit gate: pass (3 allowlisted)

Before this change, the same gate printed BLOCKING for GHSA-2m5v and GHSA-qrxm.

Unblocks #264 (the 5.1.0 release), which needs a rebase onto this.

GHSA-2m5v-pch6-74hx and GHSA-qrxm-fqhp-jwvm (both high, published
2026-10-27) fail the audit gate on every PR and on main. The lockfile's
own undici copies (6.29.1, 7.30.1) are already patched by #262; the only
affected copy is undici 6.29.0 bundled inside npm 11.21.1, which a
lockfile update or override cannot change.

npm/cli#10170 bumped the bundled undici to 6.29.1 and is merged, but it
ships in npm 11.21.2, which is not published yet. Both advisories are
allowlisted for that copy until 2026-11-15, alongside GHSA-xjj6, whose
reason now points at the merged fix instead of the closed issue.
@dlepaux
dlepaux merged commit 543eeb5 into main Oct 29, 2026
7 checks passed
github-actions Bot pushed a commit that referenced this pull request Oct 29, 2026
## [5.0.17](v5.0.16...v5.0.17) (2026-10-29)

### Bug Fixes

* **deps:** allowlist npm-bundled undici for two new TLS advisories ([#265](#265)) ([543eeb5](543eeb5)), closes [#262](#262) [npm/cli#10170](npm/cli#10170)
* **deps:** patch undici and zod advisories that turned the audit gate red ([#262](#262)) ([5484ce6](5484ce6))
* **site:** tighten the tempo readouts seen on the live pages ([c8558a3](c8558a3))
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.0.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant