Fix #21241 - ImportC: wrong static function called after linking#21242
Merged
thewilsonator merged 1 commit intodlang:masterfrom Apr 16, 2025
Merged
Fix #21241 - ImportC: wrong static function called after linking#21242thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
Fixes dlang#21241 C Static functions were being given the same externally mangled name as their identifier, which caused only one to be picked when linking with linkers that supported that. Additionally, the dmd glue code was only outputting one of these static functions as a workaround for a different linker issue. Solve this by giving C static functions a unique name (by using D mangling) and adding an `isStatic()` check to the dmd glue hack.
Contributor
|
Thanks for your pull request and interest in making D better, @drpriver! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
thewilsonator
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21241
C Static functions were being given the same externally mangled name as their identifier, which caused only one to be picked when linking with linkers that supported that.
Additionally, the dmd glue code was only outputting one of these static functions as a workaround for a different linker issue.
Solve this by giving C static functions a unique name (by using D mangling) and adding an
isStatic()check to the dmd glue hack.