Skip to content

expressionsem.d: Get rid of duplication for shift and binary bit-op expressions#17062

Merged
dlang-bot merged 2 commits intodlang:masterfrom
kinke:nodup_binexp_sema
Nov 13, 2024
Merged

expressionsem.d: Get rid of duplication for shift and binary bit-op expressions#17062
dlang-bot merged 2 commits intodlang:masterfrom
kinke:nodup_binexp_sema

Conversation

@kinke
Copy link
Copy Markdown
Contributor

@kinke kinke commented Nov 13, 2024

No description provided.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17062"

@dlang-bot dlang-bot merged commit dcecb46 into dlang:master Nov 13, 2024
@kinke kinke deleted the nodup_binexp_sema branch November 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants