Skip to content

[stable] Fix compilable/stdcheaders.c for Linux AArch64#15320

Merged
RazvanN7 merged 2 commits intodlang:stablefrom
kinke:importc_aarch64
Jun 14, 2023
Merged

[stable] Fix compilable/stdcheaders.c for Linux AArch64#15320
RazvanN7 merged 2 commits intodlang:stablefrom
kinke:importc_aarch64

Conversation

@kinke
Copy link
Copy Markdown
Contributor

@kinke kinke commented Jun 13, 2023

Upstreaming from LDC.

kinke added 2 commits June 13, 2023 16:16
For LDC CI, on Ubuntu 20.04, this fixed:
```
/usr/include/aarch64-linux-gnu/bits/floatn.h(80): Error: illegal combination of type specifiers
/usr/include/aarch64-linux-gnu/bits/floatn.h(80): Error: illegal type combination
```
when testing `compilable/stdcheaders.c`.
@kinke kinke requested a review from ibuclaw as a code owner June 13, 2023 14:21
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15320"

@RazvanN7 RazvanN7 merged commit dce1331 into dlang:stable Jun 14, 2023
@kinke kinke deleted the importc_aarch64 branch June 14, 2023 10:29
@ibuclaw ibuclaw mentioned this pull request Jun 15, 2023
the-horo added a commit to the-horo/dmd that referenced this pull request May 13, 2025
It should fix running clang-cpp on linux x86_64.

This involves moving some linux+aarch64 fixes to linux+clang since
clang was the actual issue.

See-also: dlang#15320
Signed-off-by: Andrei Horodniceanu <[email protected]>
dlang-bot pushed a commit that referenced this pull request May 13, 2025
It should fix running clang-cpp on linux x86_64.

This involves moving some linux+aarch64 fixes to linux+clang since
clang was the actual issue.

See-also: #15320
Signed-off-by: Andrei Horodniceanu <[email protected]>
kinke pushed a commit to ldc-developers/ldc that referenced this pull request May 14, 2025
It should fix running clang-cpp on linux x86_64.

This involves moving some linux+aarch64 fixes to linux+clang since
clang was the actual issue.

See-also: dlang/dmd#15320
Signed-off-by: Andrei Horodniceanu <[email protected]>
kinke pushed a commit to kinke/ldc that referenced this pull request May 17, 2025
It should fix running clang-cpp on linux x86_64.

This involves moving some linux+aarch64 fixes to linux+clang since
clang was the actual issue.

See-also: dlang/dmd#15320
Signed-off-by: Andrei Horodniceanu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants