Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
panic: send on closed channelthat occurred whenMuxis closed while thereadSessiongoroutine can still send new connections tonewConnChunder high-frequency mixed proxy (HTTP CONNECT) traffic.Description
lib/mux/mux.goupdate thereadSessionnew-connection dispatch loop to return immediately whencloseChanis signaled by addingcase <-s.closeChan: returnto theselectthat sends tonewConnCh.newConnChinMux.Close()to avoid send-on-closed races during shutdown and add a clarifying comment.Testing