Force django-compressor version #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiksprenger
force-pushed
the
feature/compressor
branch
from
e3f64c2 to
4f917c8
Compare
This commit is inspired by work in #122. We don't specify an upper bound for django-compressor in Oscar 1.0. compressor 2.0 was released, which dropped support for Django 1.7, which means our tests fail. As this is a bit of an artefact, I prefer to specify the compressor version in the testing requirements specific to the affected combination of Django and Oscar versions instead of globally as done in #122. This commit forces the version of compressor. That's good enough, given that we're about to drop Django 1.7 support as well with Oscar 1.2. Thanks go to @fghaas for the excellent analysis.
maiksprenger
force-pushed
the
feature/compressor
branch
from
4f917c8 to
4d416b0
Compare
Member
Author
|
I was trying to be too clever. #122 will be good enough :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is inspired by work in #122. We don't specify an upper bound for
django-compressor in Oscar 1.0. compressor 2.0 was released, which dropped
support for Django 1.7, which means our tests fail.
As this is a bit of an artefact, I prefer to specify the compressor version in
the testing requirements specific to the affected combination of Django and
Oscar versions instead of globally as done in #122.
This commit forces the version of compressor. That's good enough, given that
we're about to drop Django 1.7 support as well with Oscar 1.2.
Thanks go to @fghaas for the excellent analysis.