Fix Django classifiers#97
Conversation
Getting an error when trying to upload as it stands: ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/ 'Framework :: Django :: 5' is not a valid classifier. See https://packaging.python.org/specifications/core-metadata for more information.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage ? 92.87%
=======================================
Files ? 4
Lines ? 351
Branches ? 0
=======================================
Hits ? 326
Misses ? 25
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
We missed adding the trove classifier for Django 5, that exists for prior releases. I've issued a PR: They're normally pretty fast! |
|
I thought that was done on purpose, Django doesn't strictly follows semver, and there might be some breaking changes in minor releases. A package running in version X.Y is not guaranteed to work with X.Y+1 |
|
Since before my time, Django has always had trove classifiers for major versions (you can see they exist for version 1, 2, 3, and 4). Breaking changes in minor releases are fairly rare in packages, and I think have the major release classifiers allows for a bit less churn in packages, just to update their classifiers. Maybe that has changed, but I didn't see any discussion - I guess we'll see if there's any comment on the PR. 😄 |
3 participants
Getting an error when trying to upload as it stands:
Looks like we need to specify the major and minor versions now: https://pypi.org/classifiers/