Increase test coverage for renderers.py#93
Merged
FlipperPA merged 2 commits intodjango-commons:mainfrom Oct 10, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 88.53% 92.83% +4.29%
==========================================
Files 4 4
Lines 349 349
==========================================
+ Hits 309 324 +15
+ Misses 40 25 -15 ☔ View full report in Codecov by Sentry. |
browniebroke
commented
Oct 10, 2024
Comment on lines
59
to
60
| if data is None: | ||
| return bytes() |
Member
Author
There was a problem hiding this comment.
This code was unreachable, self._check_validation_data(data) raises an error if data is None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Results from my branch here: https://app.codecov.io/gh/browniebroke/drf-excel/tree/test-coverage-renderers