Bootstrap test infrastructure and add a very basic test#87
Merged
FlipperPA merged 9 commits intodjango-commons:mainfrom Sep 28, 2024
Merged
Bootstrap test infrastructure and add a very basic test#87FlipperPA merged 9 commits intodjango-commons:mainfrom
FlipperPA merged 9 commits intodjango-commons:mainfrom
Conversation
browniebroke
commented
Sep 28, 2024
.github/workflows/test.yml
Outdated
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] |
Member
Author
There was a problem hiding this comment.
Removed this to see the result on the CI on my fork: https://github.com/browniebroke/drf-excel/actions
GitHub actions don't run new PR workflow added from a forks (I think)
browniebroke
commented
Sep 28, 2024
|
|
||
| on: | ||
| pull_request: | ||
| push: |
Member
Author
There was a problem hiding this comment.
Perhaps better to add back before merging:
Suggested change
| push: | |
| push: | |
| branches: [main] |
browniebroke
commented
Sep 28, 2024
| @@ -0,0 +1,13 @@ | |||
| repos: | |||
| - repo: https://github.com/pre-commit/pre-commit-hooks | |||
Member
Author
There was a problem hiding this comment.
I didn't add anything else like ruff yet as I'd like to limit the amount of code changes in here
browniebroke
commented
Sep 28, 2024
Member
Author
There was a problem hiding this comment.
I think that's the minimal setting file required for a project to use drf-excel
Member
|
This is great, thanks for getting this started, @browniebroke! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on:
Add the test infrastructure using tox and github actions, taking inspiration from other projects in @django-commons
It might be beneficial to not add too many tests in this first PR, this way we should be able to get more folks to contribute in separate PRs to test different things.
Let me know if the approach makes sense cc @tim-schilling in case you see something that goes against something in the org