fix(windows): replace NamedTemporaryFile with TemporaryFile#74
Merged
FlipperPA merged 1 commit intodjango-commons:mainfrom Jun 23, 2023
Conversation
Windows blocked NamedTemporaryFile from saving to temp dir ... using TemporaryFile instead works fine
Member
|
Huh, it is odd that |
|
Got this problem too. The following adjustments also solved the problem: def _save_virtual_workbook(self, wb):
try:
tmp = NamedTemporaryFile(delete=False)
save_workbook(wb, tmp.name)
tmp.seek(0)
virtual_workbook = tmp.read()
finally:
tmp.close()
os.unlink(tmp.name)
return virtual_workbook |
Member
|
Sorry for the delay, just back from vacation. I'll get a version published to PyPI today. @rdmolony @AlexKovyazin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for creating & maintaining
drf-excel😃I'm running
drfonWindows Server 2019 (Datacenter)for legacy/historical reasons. This version blocksNamedTemporaryFilefrom saving to temp dir.TemporaryFileseems to work fine across platforms in its place as it is not blocked by the dreaded permissions