fix save_virtual_workbook deprecation/removal in openpyxl 3.1.0#72
Merged
FlipperPA merged 1 commit intodjango-commons:mainfrom Feb 3, 2023
Merged
Conversation
alb3rto269
changed the title
This was referenced Feb 1, 2023
Merged
Member
|
Thanks @alb3rto269 - merged to main, along with some refactoring. Let's test while I'm out of town for a day or two, and if everything looks good, I'll mint a new version on Monday. I'm also looking for a co-maintainer if you're interested; it looks like you might use the package reasonably frequently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73
The proposed solution:
save_virtual_wookbookby its non-deprecated versionsave_wookbook.save_virtual_wookbookfrom openpyxl to this repository.TemporaryFilebyNamedTemporaryFileas suggested by the openpyxl author on its deprecation message.