Update openpyxl requirements to compatiblity fix#71
Closed
TurnrDev wants to merge 1 commit intodjango-commons:mainfrom
Closed
Update openpyxl requirements to compatiblity fix#71TurnrDev wants to merge 1 commit intodjango-commons:mainfrom
TurnrDev wants to merge 1 commit intodjango-commons:mainfrom
Conversation
This was referenced Feb 1, 2023
Contributor
|
Thanks for this PR. I also created #72 with a proposal to remove the deprecated dependency. |
Merged
Member
|
Thanks for the PR, @TurnrDev - it is appreciated! I'm going to close this in lieu of #72, from @alb3rto269, which gives us compatibility with OpenPyXL 3.10+. |
Author
|
Understand, #72 is definitely a better PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drf_excel.renderers.XLSXRendererusesopenpyxl.writer.excel.save_virtual_workbookwhich has been deprecated since 2018 and removed inopenpyxl 3.1.0This is a temporary fix to solve dependency issues, but a proper fix should be to not use
save_virtual_workbook