Skip to content

Remove usage of depreciated NullBooleanField for drf 3.14.0#65

Merged
FlipperPA merged 1 commit intodjango-commons:mainfrom
sarahboyce:drf_3_14_0_support
Sep 30, 2022
Merged

Remove usage of depreciated NullBooleanField for drf 3.14.0#65
FlipperPA merged 1 commit intodjango-commons:mainfrom
sarahboyce:drf_3_14_0_support

Conversation

@sarahboyce
Copy link
Copy Markdown
Contributor

@sarahboyce sarahboyce commented Sep 23, 2022 •
edited
Loading

There is a new drf release https://www.django-rest-framework.org/community/release-notes/#3140
Here NullBooleanField is no longer available and so I removed the one reference to allow support for drf 3.14.0

It was also not required as the isinstance(field, BooleanField) would return true for a NullBooleanFIeld due to object inheritance:

>>> from rest_framework.fields import NullBooleanField
>>> field = NullBooleanField()
>>> from rest_framework.fields import BooleanField
>>> isinstance(field, BooleanField)
True
>>>

So I think we should be good 👍

Thank you for the package ❤️ @FlipperPA

@sarahboyce sarahboyce mentioned this pull request Sep 26, 2022
Closed
@FlipperPA
Copy link
Copy Markdown
Member

FlipperPA commented Sep 26, 2022

Thank you, @sarahboyce - I will take a look at this today.

@sarahboyce
Copy link
Copy Markdown
Contributor Author

sarahboyce commented Sep 30, 2022

Thank you @FlipperPA 🎉
Let me know if you need anything from me 👍

@FlipperPA FlipperPA merged commit d4f1a36 into django-commons:main Sep 30, 2022
@FlipperPA
Copy link
Copy Markdown
Member

FlipperPA commented Sep 30, 2022

Thank you, @sarahboyce!

@FlipperPA
Copy link
Copy Markdown
Member

FlipperPA commented Sep 30, 2022

Thank you! This has been published to PyPI at 2.2.0:

https://github.com/wharton/drf-excel/releases/tag/2.2.0

https://pypi.org/project/drf-excel/2.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarahboyce @FlipperPA