Update json.dumps arg in XLSXListField for Unicode characters#64
Merged
FlipperPA merged 1 commit intodjango-commons:mainfrom Sep 30, 2022
Merged
Update json.dumps arg in XLSXListField for Unicode characters#64FlipperPA merged 1 commit intodjango-commons:mainfrom
FlipperPA merged 1 commit intodjango-commons:mainfrom
Conversation
For languages with Unicode characters, ignoring `ensure_ascii` results in the Excel output of rows like
```
{
"Заголовок": "пример",
}
```
in the wrong format:
```
{
"\u0417\u0430\u0433\u043e\u043b\u043e\u0432\u043e\u043a": "\u043f\u0440\u0438\u043c\u0435\u0440",
}
```
From documentation:
>> If ensure_ascii is true (the default), the output is guaranteed to have all incoming non-ASCII characters escaped. If ensure_ascii is false, these characters will be output as-is.
suhanoves
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For languages with Unicode characters, ignoring
ensure_asciiresults in the Excel output of rows likein the wrong format:
From documentation: