Closed
Conversation
Signed-off-by: Rohan Jain <[email protected]>
Use timed signer to check for expiration of session data. This is to fix ticket django#18194. The sessions based on file backend otherwise do not expire, as far as the server is concerned. Signed-off-by: Rohan Jain <[email protected]> Conflicts: django/contrib/sessions/backends/base.py
Signed-off-by: Rohan Jain <[email protected]>
The existing sessions, which were not signed with the signing framework is handled with the older decoding method. Mark the session as modified so that it uses the new encoding method for storing the data. Signed-off-by: Rohan Jain <[email protected]> Conflicts: django/contrib/sessions/backends/base.py
Don't enable compatibility with older mechanism by default as it compromises with the security benefits of introducing signing framework. Signed-off-by: Rohan Jain <[email protected]>
Signed-off-by: Rohan Jain <[email protected]>
Author
|
Is this relevant now? The changes are from 13+ year ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #18194