Refs #31710 -- Fixed multiple file upload documentation.#18044
Merged
nessita merged 1 commit intodjango:mainfrom Apr 4, 2024
Merged
Refs #31710 -- Fixed multiple file upload documentation.#18044nessita merged 1 commit intodjango:mainfrom
nessita merged 1 commit intodjango:mainfrom
Conversation
Member
Author
|
Sorry for the post-retirement ping @felixxm 🏖️ |
685e222 to
e06069e
Compare
e06069e to
d8437c7
Compare
nessita
approved these changes
Apr 4, 2024
Contributor
nessita
left a comment
There was a problem hiding this comment.
Looks great! I pushed a small edition in the same section, will merge once CI passes. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-31710
Branch description
Fix two issues in this documentation added in fb4c55d.
First, a small tweak to make the widget consistently return a list of files. Without this, it would break the sample view code’s iteration (
for f in files) when the form’sfilesis not aMultiValueDict, which is typically used in testing.Before:
After:
Second, remove the redundant
post()from the view, and fix the call tosuper().form_valid()to passform. Thepost()method only duplicatedProcessFormViewwith nothing extra added for multiple file handling. Thesuper()call crashed withTypeErrordue to the missing argument.Before:
After:
Checklist
mainbranch.