Fixed #35306 -- Improved documentation for the various date format settings#18028
Merged
sarahboyce merged 1 commit intodjango:mainfrom Jun 24, 2024
Merged
Fixed #35306 -- Improved documentation for the various date format settings#18028sarahboyce merged 1 commit intodjango:mainfrom
sarahboyce merged 1 commit intodjango:mainfrom
Conversation
Contributor
|
@lufafajoshua thank you for your work. When this PR is ready for review, please update the checklist from the PR description, and don't forget to set the proper ticket flags for this to be listed in the branches needing review. |
claudep
requested changes
Apr 13, 2024
sarahboyce
reviewed
May 5, 2024
Contributor
sarahboyce
left a comment
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you for this @lufafajoshua ⭐ I have a few comments
Can you also update the PR title to better represent what this PR is trying to acheive?
6 tasks
sarahboyce
changed the title
… when localization is disabled.
sarahboyce
approved these changes
Jun 24, 2024
Contributor
sarahboyce
left a comment
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you @lufafajoshua 👍 this looks good to me!
I have squashed commits and applied minor updates, want to check other people are happy before merging but I think we're very close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35306
Branch description
Updated documentation on localization formats usage and precedence.
Checklist
mainbranch.