Fixed #35333 -- Ensured that date and time filters honor the unlocalize tag. #18021
Fixed #35333 -- Ensured that date and time filters honor the unlocalize tag. #18021claudep wants to merge 2 commits intodjango:mainfrom
Conversation
3e380f7 to
1e74dda
Compare
1e74dda to
859ffe6
Compare
Co-authored-by: Natalia Bidart <[email protected]>
859ffe6 to
90862f4
Compare
|
Hi, I see this PR has been open for a while. Is there any update on this, or would you be open to me taking over and addressing any remaining issues? |
Hello @AhmedNassar7! I think you can take on this and address the remaining issues. There are comments from me in the two mentioned tickets, so if you can double check that all those suggestions are covered, I would be happy to review your PR. For the PR to be listed as "needing review" in the Django Development Dashboard, please remember to set the proper Trac flags in the ticket as described in the PR checklist when this is ready for review. So the "has patch" flag has to be set in the ticket (and the flags for needs docs/needs tests/needs improvements needs to be unset). @claudep shall we close this to allow alternative PRs? Honestly I can't remember why we did not push this PR forward, was it "just" that the flags in the ticket were not set? 🤔 |
|
I'm sorry, I don't remember at all why this PR did not go forward, or why it was not linked on the ticket. I'm getting old 👴 |
No worries, I'm on the same boat! Are you ok with @AhmedNassar7 taking this over? Or would you like to resurface it yourself? |
|
No problem, @AhmedNassar7 can continue the work. |
|
Hi @nessita, I've reviewed the changes and run the tests, all of which are passing. However, I couldn't find specific comments or suggestions in the tickets that needed addressing. Could you please confirm if there's anything specific I might have missed? |
|
I will submit my own PR. |
Refs #35306.