Skip to content

Fixed #35333 -- Ensured that date and time filters honor the unlocalize tag. #18021

Closed
claudep wants to merge 2 commits intodjango:mainfrom
claudep:unlocalize_test
Closed

Fixed #35333 -- Ensured that date and time filters honor the unlocalize tag. #18021
claudep wants to merge 2 commits intodjango:mainfrom
claudep:unlocalize_test

Conversation

@claudep
Copy link
Copy Markdown
Member

@claudep claudep commented Mar 26, 2024

Refs #35306.

@claudep claudep force-pushed the unlocalize_test branch 2 times, most recently from 3e380f7 to 1e74dda Compare March 26, 2024 17:48
@nessita nessita changed the title WIP: Test and fix unlocalize effect Fixed #35333 -- Ensured that date and time filters honor the unlocalize tag. Mar 26, 2024
@AhmedNassar7
Copy link
Copy Markdown
Contributor

Hi, I see this PR has been open for a while. Is there any update on this, or would you be open to me taking over and addressing any remaining issues?

@nessita
Copy link
Copy Markdown
Contributor

nessita commented Mar 27, 2025

Hi, I see this PR has been open for a while. Is there any update on this, or would you be open to me taking over and addressing any remaining issues?

Hello @AhmedNassar7! I think you can take on this and address the remaining issues. There are comments from me in the two mentioned tickets, so if you can double check that all those suggestions are covered, I would be happy to review your PR.

For the PR to be listed as "needing review" in the Django Development Dashboard, please remember to set the proper Trac flags in the ticket as described in the PR checklist when this is ready for review. So the "has patch" flag has to be set in the ticket (and the flags for needs docs/needs tests/needs improvements needs to be unset).

@claudep shall we close this to allow alternative PRs? Honestly I can't remember why we did not push this PR forward, was it "just" that the flags in the ticket were not set? 🤔

@claudep
Copy link
Copy Markdown
Member Author

claudep commented Mar 27, 2025

I'm sorry, I don't remember at all why this PR did not go forward, or why it was not linked on the ticket. I'm getting old 👴

@nessita
Copy link
Copy Markdown
Contributor

nessita commented Mar 28, 2025

I'm sorry, I don't remember at all why this PR did not go forward, or why it was not linked on the ticket. I'm getting old 👴

No worries, I'm on the same boat! Are you ok with @AhmedNassar7 taking this over? Or would you like to resurface it yourself?

@claudep
Copy link
Copy Markdown
Member Author

claudep commented Mar 28, 2025

No problem, @AhmedNassar7 can continue the work.

@AhmedNassar7
Copy link
Copy Markdown
Contributor

AhmedNassar7 commented Mar 28, 2025

Hi @nessita and @claudep,

Thanks for the confirmation! I’d be happy to make PR, address the remaining issues, and ensure all comments are covered. I'll also update the Trac flags when it's ready for review.

@AhmedNassar7
Copy link
Copy Markdown
Contributor

Hi @nessita,

I've reviewed the changes and run the tests, all of which are passing. However, I couldn't find specific comments or suggestions in the tickets that needed addressing. Could you please confirm if there's anything specific I might have missed?

@AhmedNassar7
Copy link
Copy Markdown
Contributor

I will submit my own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants